ADFA-1807 | Add actionable feedback for local model load failures - #52
Open
jatezzz wants to merge 1 commit into
Open
ADFA-1807 | Add actionable feedback for local model load failures#52jatezzz wants to merge 1 commit into
jatezzz wants to merge 1 commit into
Conversation
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review for a one-time review, or @claude review always to subscribe this PR to a review on every future push.
Tip: disable this comment in your organization's Code Review settings.
jatezzz
requested review from
a team,
Daniel-ADFA,
dara-abijo-adfa,
hal-eisen-adfa and
itsaky-adfa
July 28, 2026 15:21
jatezzz
force-pushed
the
feature/ADFA-1807-model-load-error-feedback
branch
4 times, most recently
from
July 30, 2026 16:48
017080b to
027918d
Compare
hal-eisen-adfa
approved these changes
Jul 30, 2026
Contributor
|
We should test this with a larger model |
jatezzz
force-pushed
the
feature/ADFA-1807-model-load-error-feedback
branch
from
July 31, 2026 15:26
027918d to
19db609
Compare
Refactors model loading to diagnose errors (e.g., low memory, invalid format) and provide clear, user-facing messages.
jatezzz
force-pushed
the
feature/ADFA-1807-model-load-error-feedback
branch
from
July 31, 2026 15:34
19db609 to
c2ac2eb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added diagnostic classes (
ModelLoadDiagnostics,ModelLoadMessages) to inspect.gguffiles and memory states. This provides accurate, user-friendly error messages when local AI models fail to load, greatly improving the AI assistant's user experience.Details
GgufFileInspectorto validate file headers efficiently.ModelLoadDiagnosticsto categorize specific load errors (e.g., Low Memory, Not GGUF, File Missing).LocalLlmBackendto utilize the new diagnostic tools and fail gracefully.document_5136658230339965297.mp4
Ticket
ADFA-1807
Observation
Logic was deliberately split into pure functions/objects without Android
Contextwhere possible to ensure the diagnostic behavior remains fully unit-testable off-device. Teardown logic inLocalLlmBackendwas also moved to a dedicatedSupervisorJobto prevent orphan jobs.